added feature post_init_post_parse by sevaho · Pull Request #567 · pydantic/pydantic

sevaho · 2019-05-31T10:01:21Z

Change Summary

Now you can have __post_init_post_parse__ that runs after pydantic has validated the input.

So __init__() -> __post_init__() -> pydantic object validation -> __post_init_post_parse__()

Related issue number

#566

Checklist

Unit tests for the changes exist
Tests pass on CI and coverage remains at 100%
Documentation reflects the changes where applicable
HISTORY.rst has been updated
- if this is the first change since a release, please add a new section
- include the issue number or this pull request number #<number>
- include your github username @<whomever>

samuelcolvin · 2019-05-31T10:06:35Z

Looking good, needs tests and docs.

… post_init_original is set

codecov · 2019-06-01T09:46:02Z

Codecov Report

Merging #567 into master will decrease coverage by 0.08%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage     100%   99.91%   -0.09%     
==========================================
  Files          15       15              
  Lines        2491     2497       +6     
  Branches      497      499       +2     
==========================================
+ Hits         2491     2495       +4     
- Misses          0        1       +1     
- Partials        0        1       +1

sevaho · 2019-06-01T09:47:28Z

I don't understand why tests fail tho, if I install it locally it works :/

    def test_post_init_post_parse():
        post_init_called = False
        post_init_post_parse_called = False
    
        @pydantic.dataclasses.dataclass
        class MyDataclass:
            a: int
    
            def __post_init__(self):
                nonlocal post_init_called
                post_init_called = True
    
            def __post_init_post_parse__(self):
                nonlocal post_init_post_parse_called
                post_init_post_parse_called = True
    
        d = MyDataclass("1")
        assert d.a == 1
        assert post_init_called
>       assert post_init_post_parse_called
E       assert False

samuelcolvin · 2019-06-01T10:36:07Z

please revert to single quotes, then I'll review.

sevaho · 2019-06-01T11:40:24Z

Sorry, autoformatter on save ;)

sevaho · 2019-06-01T13:06:07Z

Yeah you were right hasattr is not the way to go ;)

Also added a test which shows the difference between post_init and post_init_post_parse:

def test_post_init_post_parse_types():
    @pydantic.dataclasses.dataclass
    class CustomType(object):
        b: int

    @pydantic.dataclasses.dataclass
    class MyDataclass:
        a: CustomType

        def __post_init__(self):
            assert type(self.a) == dict

        def __post_init_post_parse__(self):
            assert type(self.a) == CustomType

    d = MyDataclass(**{"a": {"b": 1}})
    assert d.a.b == 1

Will add some docs now

samuelcolvin

Looking good, please update history and docs.

samuelcolvin · 2019-06-01T13:06:52Z

@@ -0,0 +1,20 @@
+import pydantic


remove this file please.

…ecause it broke the original flow

sevaho · 2019-06-01T14:05:05Z

Added docs and update history.

I think this should be in a new version because it is a new feature? If not I update the version back to 0.27 and it my update to history to 0.27 aswell.

samuelcolvin

just a few small things, otherwise looking good.

codecov · 2019-06-01T14:15:15Z

Codecov Report

Merging #567 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #567   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines        2491   2495    +4     
  Branches      497    498    +1     
=====================================
+ Hits         2491   2495    +4

Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>

samuelcolvin

Best to run tests before you commit to avoid simple problems like this.

samuelcolvin · 2019-06-02T09:55:42Z


+v0.28 (unreleased)
+..................
+* support ``__post_init_post_parse__`` support to dataclasses, #567 by @sevaho


samuelcolvin · 2019-06-02T09:56:47Z

+    post_init_post_parse = getattr(_cls, '__post_init_post_parse__', None)
    if post_init_original and post_init_original.__name__ == '_pydantic_post_init':
        post_init_original = None
+    if post_init_post_parse:


this is wrong, it needs to be removed completely, I guess this is why tests are failing.

sevaho · 2019-06-02T13:50:40Z

Idd it had no use

…o post_init_post_parse

samuelcolvin · 2019-06-04T09:01:15Z

great, thanks.

* fix: copy with tzinfo * fix: apply feedback

added feature post_init_post_parse

8b981d7

sevaho mentioned this pull request May 31, 2019

Pre and post parsing triggers for dataclasses #566

Closed

fixed bug where post_init_post_parse was triggered without looking is…

621a5a0

… post_init_original is set

change double to single quotes

6f2e26c

__doc__ strings fixed back to double quote

ebef2d2

samuelcolvin reviewed Jun 1, 2019

View reviewed changes

Comment thread pydantic/dataclasses.py Outdated

added better way of doing the post_init_post_parse also tests passes now

54505c0

samuelcolvin reviewed Jun 1, 2019

View reviewed changes

sevaho added 4 commits June 1, 2019 15:07

removed unused file

4b1ee65

deleted unnecessary test

c2a08c8

update history.rst, changed previouis change 560 to breaking change b…

f8dc012

…ecause it broke the original flow

update docs, added section post_init_post_parse under dataclasses

5c497ce

added __post_init_post_parse__ as attribute of DataclassType

136126f

samuelcolvin reviewed Jun 1, 2019

View reviewed changes

Comment thread HISTORY.rst Outdated

Comment thread docs/index.rst Outdated

Comment thread HISTORY.rst Outdated

Comment thread pydantic/dataclasses.py Outdated

sevaho and others added 5 commits June 1, 2019 16:45

Update HISTORY.rst

e325da8

Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>

Update HISTORY.rst

c37e461

Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>

Update pydantic/dataclasses.py

fa08538

Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>

update docs, added subsection initialize hooks under dataclasses

2cbab26

my bad

617449a

samuelcolvin reviewed Jun 2, 2019

View reviewed changes

sevaho added 2 commits June 2, 2019 15:48

make tests work again

2d90f39

removed checking if post_init_parse is none

7cf8c43

samuelcolvin and others added 3 commits June 3, 2019 09:39

correct typo in history

ba2a3f3

fixed typo in history.rst

a39e729

Merge branch 'post_init_post_parse' of github.com:sevaho/pydantic int…

0520ce2

…o post_init_post_parse

samuelcolvin merged commit 2a04aa7 into pydantic:master Jun 4, 2019

samuelcolvin mentioned this pull request Jan 22, 2020

different post_init behavior for dataclass across pydantic versions #1187

Closed

alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023

fix: copy with tzinfo (pydantic#567)

9f69da1

* fix: copy with tzinfo * fix: apply feedback

Uh oh!

Conversation

sevaho commented May 31, 2019 • edited by samuelcolvin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change Summary

Related issue number

Checklist

Uh oh!

samuelcolvin commented May 31, 2019

Uh oh!

codecov Bot commented Jun 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sevaho commented Jun 1, 2019

Uh oh!

samuelcolvin commented Jun 1, 2019

Uh oh!

sevaho commented Jun 1, 2019

Uh oh!

Uh oh!

sevaho commented Jun 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samuelcolvin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

samuelcolvin Jun 1, 2019

Choose a reason for hiding this comment

Uh oh!

sevaho commented Jun 1, 2019

Uh oh!

samuelcolvin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jun 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

samuelcolvin left a comment

Choose a reason for hiding this comment

Uh oh!

samuelcolvin Jun 2, 2019

Choose a reason for hiding this comment

Uh oh!

samuelcolvin Jun 2, 2019

Choose a reason for hiding this comment

Uh oh!

sevaho commented Jun 2, 2019

Uh oh!

samuelcolvin commented Jun 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sevaho commented May 31, 2019 •

edited by samuelcolvin

Loading

codecov Bot commented Jun 1, 2019 •

edited

Loading

sevaho commented Jun 1, 2019 •

edited

Loading

codecov Bot commented Jun 1, 2019 •

edited

Loading