Fix imports indirectly from pydantic typing#4358
Fix imports indirectly from pydantic typing#4358samuelcolvin merged 8 commits intopydantic:masterfrom
Conversation
|
This will also close #4182 to keep consistency in |
Thanks, if this is closing issues, please put them in the PR body so they get auto-closed. Please update. |
|
please review |
|
Thanks @aminalaee for the patch 👍 There are some other
|
|
please update |
|
Thank you for the review @hramezani . I'd only checked the top imports, this should be ok now. please review. |
hramezani
left a comment
There was a problem hiding this comment.
Thanks @aminalaee for the update 👍
|
Hi @aminalaee please update to add a change file. Otherwise LGTM. |
|
Sorry I'd forgotten to add that. please review again. |
|
Thanks so much. |
current pydantic 1.10.2 see pydantic/pydantic#4358 Fix imports indirectly from pydantic typing #4358
Change Summary
Some imports indirectly get
ForwardRefand other types from.typinginstead oftypingmodule. I came across this when I was working on something else.Closes #4182
Related issue number
None
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)