reame get_validators > __get_validators__#338
Merged
samuelcolvin merged 2 commits intomasterfrom Dec 27, 2018
Merged
Conversation
c76d609 to
ff592dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 1801 1828 +27
Branches 350 369 +19
=====================================
+ Hits 1801 1828 +27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Rename
get_validatorsto__get_validators__on custom classes to be more like dataclasses (ref #334), also because it's a more sensible name.Raise a depreciation warning on use of the old name.
We'll remove
get_validatorsusage and warning in future.Checklist
HISTORY.rsthas been updated#<number>@whatever