Skip to content

Simple iterables schema generation#335

Merged
samuelcolvin merged 3 commits intopydantic:masterfrom
nkonin:simple_iterables_schema_generation
Dec 27, 2018
Merged

Simple iterables schema generation#335
samuelcolvin merged 3 commits intopydantic:masterfrom
nkonin:simple_iterables_schema_generation

Conversation

@nkonin
Copy link
Copy Markdown
Contributor

@nkonin nkonin commented Dec 27, 2018 •
edited
Loading

Change Summary

schema generation for : list, : tuple and : set annotations.

Related issue number

No

Performance Changes

Not run

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes | It was already in docs, this PR just fix
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • if you're not a regular contributer please include your github username @whatever

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 27, 2018 •
edited
Loading

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #335   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines        1783   1801   +18     
  Branches      347    350    +3     
=====================================
+ Hits         1783   1801   +18

@samuelcolvin
Copy link
Copy Markdown
Member

samuelcolvin commented Dec 27, 2018

ref #330 and #331.

samuelcolvin
samuelcolvin reviewed Dec 27, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM, @tiangolo?

Comment thread HISTORY.rst Outdated
@samuelcolvin samuelcolvin merged commit e28d689 into pydantic:master Dec 27, 2018
@tiangolo
Copy link
Copy Markdown
Contributor

tiangolo commented Dec 28, 2018

Awesome! 🎉

alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023
@art049
switch codspeed to tokenless uploads (pydantic#335)
7eb555b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelcolvin samuelcolvin samuelcolvin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nkonin @samuelcolvin @tiangolo