mypy: Add create_model overload#2748
Merged
PrettyWood merged 4 commits intopydantic:masterfrom Sep 4, 2021
Merged
Conversation
Contributor
Author
|
please review |
sbv-csis
reviewed
May 10, 2021
PrettyWood
approved these changes
Sep 4, 2021
Contributor
PrettyWood
left a comment
There was a problem hiding this comment.
Great! Thank you so much
jpribyl
pushed a commit
to liquet-ai/pydantic
that referenced
this pull request
Oct 7, 2021
* Add create_model overload * Add changes * fix: import Co-authored-by: PrettyWood <em.jolibois@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add create_model overload
Currently
mypywill fail on this code:With this PR
mypywill correctly resolve return value type ofcreate_model:And it will still work for a cases when
__base__is specified:Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)