Skip to content

docs preview and coverage using smokeshow#2580

Merged
samuelcolvin merged 10 commits intomasterfrom
smokeshow
Mar 27, 2021
Merged

docs preview and coverage using smokeshow#2580
samuelcolvin merged 10 commits intomasterfrom
smokeshow

Conversation

@samuelcolvin
Copy link
Copy Markdown
Member

@samuelcolvin samuelcolvin commented Mar 25, 2021 •
edited
Loading

Change Summary

Switch from my bodged solution for docs preview to use smokeshow

I also want to use smokeshow instead of codecov, because:

  • codecovs bugs and outages are beginning to annoy me
  • pydantic has 100%, so any missing coverage on a PR is the fault of that PR - codecov's clever feature for showing coverage changes are not needed

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@pydantic pydantic deleted a comment from codecov Bot Mar 27, 2021
@samuelcolvin samuelcolvin changed the title docs preview using smokeshow docs preview and coverage using smokeshow Mar 27, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2021 •
edited
Loading

Codecov Report

Merging #2580 (e328ff5) into master (7b7e705) will not change coverage.
The diff coverage is n/a.

❗ Current head e328ff5 differs from pull request most recent head 5b29695. Consider uploading reports for the commit 5b29695 to get more accurate results

@@            Coverage Diff            @@
##            master     #2580   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         5109      5109           
  Branches      1050      1050           
=========================================
  Hits          5109      5109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7e705...5b29695. Read the comment docs.

@samuelcolvin samuelcolvin mentioned this pull request Mar 27, 2021
Closed
@samuelcolvin samuelcolvin marked this pull request as ready for review March 27, 2021 18:02
@samuelcolvin samuelcolvin merged commit 9082579 into master Mar 27, 2021
@samuelcolvin samuelcolvin deleted the smokeshow branch March 27, 2021 18:36
MihanixA pushed a commit to MihanixA/pydantic that referenced this pull request Apr 5, 2021
@samuelcolvin @MihanixA
docs preview and coverage using smokeshow (pydantic#2580)
69a342f 
* docs preview using smokeshow

* switch to using smokeshow for coverage

* fix macos and windows builds

* correct coverage prep.

* tweak coverage build logic

* print more coverage info

* mess with coverage setup, set config [PATHS]

* updating badges

* add context to coverage reports

* adding smokeshow status context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samuelcolvin