Fix issue with config decl at class level#2532
Merged
samuelcolvin merged 4 commits intopydantic:masterfrom May 9, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2532 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 5109 5110 +1
Branches 1050 1051 +1
=========================================
+ Hits 5109 5110 +1
Continue to review full report at Codecov.
|
PrettyWood
reviewed
Mar 16, 2021
Contributor
PrettyWood
left a comment
There was a problem hiding this comment.
LGTM otherwise thanks!
Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>
Member
|
great, thank you so much. |
samuelcolvin
pushed a commit
that referenced
this pull request
May 11, 2021
* Fix issue with config decl at class level * Add changes * Update pydantic/main.py Co-authored-by: Eric Jolibois <em.jolibois@gmail.com> * Update changes Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix issue with config decl at class level
Related issue number
Fixes #2522
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)