Make sure None is converted as NoneType in Python 3.14#12370
Merged
Conversation
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
CodSpeed Performance ReportMerging #12370 will not alter performanceComparing Summary
|
davidhewitt
reviewed
Oct 10, 2025
| ) -> Any: | ||
| if sys.version_info >= (3, 13): | ||
| if sys.version_info >= (3, 14): | ||
| # Starting in 3.14, `_eval_type()` does *not* apply `_type_convert()` |
Collaborator
There was a problem hiding this comment.
Did _type_convert() do anything else, do those cases also matter?
Member
Author
There was a problem hiding this comment.
It converts str values to forward refs, but this is already handled by _eval_type() so after calling it we are guaranteed to not have to deal with forward refs anymore.
davidhewitt
approved these changes
Oct 11, 2025
|
Thank you for fixing it so quickly. Is there any timeline on when this will get released into a new pydantic version? |
2 tasks
Member
Author
|
We are aiming for a first patch release today. |
Viicos
added a commit
that referenced
this pull request
Oct 13, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes #12368.
Related issue number
Checklist