Do not evaluate annotations when inspecting validators and serializers#12355
Merged
Do not evaluate annotations when inspecting validators and serializers#12355
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
7021708
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7dff2d69.pydantic-docs.pages.dev |
| Branch Preview URL: | https://signature-no-eval.pydantic-docs.pages.dev |
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
CodSpeed Performance ReportMerging #12355 will improve performances by 6.47%Comparing Summary
Benchmarks breakdown
|
davidhewitt
reviewed
Oct 8, 2025
| assert A(a='1').a == 1 | ||
|
|
||
|
|
||
| def test_deferred_annotations_return_values() -> None: |
Collaborator
There was a problem hiding this comment.
Worth testing wrap forms too?
Member
Author
There was a problem hiding this comment.
The decorated function inspection doesn't special case modes, so I think this should be fine
davidhewitt
approved these changes
Oct 8, 2025
Viicos
added a commit
that referenced
this pull request
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes #12353.
Related issue number
Checklist