Skip to content

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Oct 7, 2025

Change Summary

Fixes #11962.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos requested a review from davidhewitt October 7, 2025 09:52
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 7, 2025
Comment on lines +2336 to +2341
and (
unused_metadata_name not in ('validation_alias', 'serialization_alias')
or 'alias' not in field_info._attributes_set
):
unused_metadata.append((unused_metadata_name, unused_metadata_value))
)
):
unused_metadata.append((unused_metadata_name, unused_metadata_value))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated simplification.

@cloudflare-workers-and-pages
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b7ea431
Status: ✅  Deploy successful!
Preview URL: https://5a2c0904.pydantic-docs.pages.dev
Branch Preview URL: https://validate-call-validation-ali.pydantic-docs.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total  

This report was generated by python-coverage-comment-action

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 7, 2025

CodSpeed Performance Report

Merging #12340 will not alter performance

Comparing validate-call-validation-alias (b7ea431) with main (21c7d92)

Summary

✅ 46 untouched

@Viicos Viicos merged commit 82d4254 into main Oct 7, 2025
66 checks passed
@Viicos Viicos deleted the validate-call-validation-alias branch October 7, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validate_by_alias does not work with validate_call

3 participants