Do not error on fields overridden by methods in the mypy plugin#12290
Merged
Do not error on fields overridden by methods in the mypy plugin#12290
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
1b4dde9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://58a39027.pydantic-docs.pages.dev |
| Branch Preview URL: | https://mypy-plugin-frozen-overridde.pydantic-docs.pages.dev |
davidhewitt
reviewed
Sep 29, 2025
| parent_attr: str = Field(exclude=True) | ||
|
|
||
|
|
||
| # We don't wan't to froze `parent_attr` in the plugin: |
Collaborator
There was a problem hiding this comment.
Why not? also typo should be "freeze"
Member
Author
There was a problem hiding this comment.
See the fixed issue, it results in unexpected errors.
Collaborator
There was a problem hiding this comment.
I see, maybe this is clearer:
Suggested change
| # We don't wan't to froze `parent_attr` in the plugin: | |
| # `parent_attr` is writable, mypy should error when overriding with a read-only property |
|
|
||
|
|
||
| # We don't wan't to froze `parent_attr` in the plugin: | ||
| class Chield(Parent): |
Collaborator
There was a problem hiding this comment.
Suggested change
| class Chield(Parent): | |
| class Child(Parent): |
Collaborator
There was a problem hiding this comment.
Doesn't look like this suggestion was applied?
Member
Author
There was a problem hiding this comment.
Hum I don't see it on the diff?
CodSpeed Performance ReportMerging #12290 will improve performances by 5.19%Comparing Summary
Benchmarks breakdown
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
5217563 to
feb23f9
Compare
feb23f9 to
5a3337d
Compare
davidhewitt
approved these changes
Sep 30, 2025
Collaborator
davidhewitt
left a comment
There was a problem hiding this comment.
I see, I understand now
| parent_attr: str = Field(exclude=True) | ||
|
|
||
|
|
||
| # We don't wan't to froze `parent_attr` in the plugin: |
Collaborator
There was a problem hiding this comment.
I see, maybe this is clearer:
Suggested change
| # We don't wan't to froze `parent_attr` in the plugin: | |
| # `parent_attr` is writable, mypy should error when overriding with a read-only property |
|
|
||
|
|
||
| # We don't wan't to froze `parent_attr` in the plugin: | ||
| class Chield(Parent): |
Collaborator
There was a problem hiding this comment.
Doesn't look like this suggestion was applied?
Viicos
commented
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Also update mypy to 1.18 and update tests.
Fixes #12278.
Related issue number
Checklist