Skip to content

Add __qualname__ parameter for create_model#12001

Merged
Viicos merged 5 commits intopydantic:mainfrom
Atry:patch-1
Oct 7, 2025
Merged

Add __qualname__ parameter for create_model#12001
Viicos merged 5 commits intopydantic:mainfrom
Atry:patch-1

Conversation

@Atry
Copy link
Copy Markdown
Contributor

@Atry Atry commented Jun 20, 2025 •
edited by pydantic-hooky Bot
Loading

Change Summary

This PR adds __qualname__ argument for create_model as described in https://peps.python.org/pep-3155/

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @Viicos

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Jun 20, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12001 will degrade performances by 6.24%

Comparing Atry:patch-1 (2b576e9) with main (28c62c3)

Summary

❌ 1 regression
✅ 45 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ test_model_validators_serializers 762.6 µs 813.4 µs -6.24%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 20, 2025 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  main.py
Project Total  

This report was generated by python-coverage-comment-action

@Atry
Copy link
Copy Markdown
Contributor Author

Atry commented Aug 22, 2025

please review

@Atry Atry marked this pull request as ready for review August 22, 2025 06:54
Viicos
Viicos reviewed Oct 7, 2025
View reviewed changes
Comment thread pydantic/main.py Outdated
Viicos
Viicos reviewed Oct 7, 2025
View reviewed changes
Comment thread pydantic/main.py Outdated
@Viicos Viicos changed the title feat: add __qualname__ argument for create_model Add __qualname__ argument for create_model Oct 7, 2025
@Viicos Viicos changed the title Add __qualname__ argument for create_model Add __qualname__ parameter for create_model Oct 7, 2025
Viicos
Viicos approved these changes Oct 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Atry

@Viicos Viicos enabled auto-merge (squash) October 7, 2025 14:17
@Viicos Viicos merged commit 3f59a03 into pydantic:main Oct 7, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Viicos Viicos Viicos approved these changes

Assignees

@Viicos Viicos

Labels

relnotes-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Atry @Viicos