Skip to content

Always store the original field assignment on FieldInfo#11946

Merged
Viicos merged 1 commit intomainfrom
store-original-assignment
Jun 12, 2025
Merged

Always store the original field assignment on FieldInfo#11946
Viicos merged 1 commit intomainfrom
store-original-assignment

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Jun 4, 2025

Change Summary

Fixes #11920.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos added relnotes-fix Used for bugfixes. third-party-tests Add this label on a PR to trigger 3rd party tests backport-2.11 labels Jun 4, 2025
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b0785ec
Status: ✅  Deploy successful!
Preview URL: https://51b2392f.pydantic-docs.pages.dev
Branch Preview URL: https://store-original-assignment.pydantic-docs.pages.dev

View logs

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _fields.py
Project Total  

This report was generated by python-coverage-comment-action

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 4, 2025

CodSpeed Performance Report

Merging #11946 will not alter performance

Comparing store-original-assignment (b0785ec) with main (88c75cd)

Summary

✅ 46 untouched benchmarks

@Viicos Viicos merged commit bcd10f7 into main Jun 12, 2025
130 of 136 checks passed
@Viicos Viicos deleted the store-original-assignment branch June 12, 2025 19:25
Viicos added a commit that referenced this pull request Jun 12, 2025
Viicos added a commit that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes. third-party-tests Add this label on a PR to trigger 3rd party tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FieldInfo lost after applying model_rebuild with _types_namespace on parameterized generic model with forward reference

2 participants