Skip to content

Traverse function-before schemas during schema gathering#11801

Merged
Viicos merged 1 commit intomainfrom
gather-function-before
Apr 29, 2025
Merged

Traverse function-before schemas during schema gathering#11801
Viicos merged 1 commit intomainfrom
gather-function-before

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Apr 28, 2025

Change Summary

Fixes #11800.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Apr 28, 2025
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b97f008
Status: ✅  Deploy successful!
Preview URL: https://1e6301e6.pydantic-docs.pages.dev
Branch Preview URL: https://gather-function-before.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 28, 2025

CodSpeed Performance Report

Merging #11801 will not alter performance

Comparing gather-function-before (b97f008) with main (7df0816)

Summary

✅ 46 untouched benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _schema_gather.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos merged commit 5e300c3 into main Apr 29, 2025
64 checks passed
@Viicos Viicos deleted the gather-function-before branch April 29, 2025 11:33
Viicos added a commit that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON Schema generation fails when before validator's json_schema_input_type set to a model that is not referenced in the class

2 participants