Properly validate parameterized mappings#11658
Merged
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
a071a50
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://36bb88bf.pydantic-docs.pages.dev |
| Branch Preview URL: | https://mapping-regression.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11658 will not alter performanceComparing Summary
|
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
davidhewitt
approved these changes
Apr 2, 2025
Collaborator
davidhewitt
left a comment
There was a problem hiding this comment.
LGTM with one comment
Comment on lines
6957
to
6958
| Note - we still don't do a good job of handling subclasses, as we convert the input to a dict | ||
| via the MappingValidator annotation's schema. |
Collaborator
There was a problem hiding this comment.
Is this comment now out of date?
Member
Author
There was a problem hiding this comment.
Good catch -- well the MappingValidator is not a thing anymore but I think the comment is still relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes #11650.
Regression in #11247, the logic was somehow tweaked when moved to the
GenerateSchemaclass, so it was restored to how it was before.Related issue number
Checklist