Add encoded_string() method to the URL types#11580
Merged
Viicos merged 5 commits intopydantic:mainfrom Mar 19, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #11580 will not alter performanceComparing Summary
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Viicos
requested changes
Mar 19, 2025
Member
Viicos
left a comment
There was a problem hiding this comment.
Thanks for the contribution. The encoded() method needs to be added on _BaseMultiHostUrl as well.
| # https://www.xudongz.com/blog/2017/idn-phishing/ accepted but converted | ||
| ('https://www.аррӏе.com/', 'https://www.xn--80ak6aa92e.com/'), | ||
| ('https://exampl£e.org', 'https://xn--example-gia.org/'), | ||
| ('http://puny£code.com', 'http://xn--punycode-eja.com/'), |
Member
There was a problem hiding this comment.
Suggested change
| ('http://puny£code.com', 'http://xn--punycode-eja.com/'), |
Viicos
reviewed
Mar 19, 2025
Contributor
Author
|
@Viicos can u take a look on the new _BaseMultiHostUrl test that I have added |
encoded_string() method to the URL types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR introduces a new
encodedproperty to theUrlclass inpydantic/networks.py. Theencodedproperty returns the punycode-encoded host version of the URL as a string. Additionally, a new test case has been added totests/test_networks.pyto verify the functionality of theencodedproperty.Related issue number
fixes #11551
Checklist
The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers