Always include additionalProperties: True for arbitrary dictionary schemas#11392
Merged
Viicos merged 1 commit intopydantic:mainfrom Feb 7, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #11392 will not alter performanceComparing Summary
|
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Contributor
Author
|
please review |
Viicos
approved these changes
Feb 5, 2025
Member
Viicos
left a comment
There was a problem hiding this comment.
This LGTM I'll merge soon if I don't see any objections
Contributor
|
Fine by me! |
1 task
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
For following example, an extra
additionalProperties: Truewill be added to the existing json schema.The same rule will be applied to all fields of the following model.
Related issue number
fix #11318
Checklist
Selected Reviewer: @sydney-runkle