Skip to content

Improve exception message when encountering recursion errors during type evaluation#11356

Merged
Viicos merged 2 commits intomainfrom
typealias-recursionerror
Feb 1, 2025
Merged

Improve exception message when encountering recursion errors during type evaluation#11356
Viicos merged 2 commits intomainfrom
typealias-recursionerror

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Jan 29, 2025

Follow up on #11355.

Closes #10873, closes #11320, closes #9946, closes #8785, closes #8346, closes #8073, closes #8021.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Jan 29, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 29, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11356 will not alter performance

Comparing typealias-recursionerror (7b4cecd) with main (05daaa9)

Summary

✅ 45 untouched benchmarks

@Viicos Viicos force-pushed the typealias-recursionerror branch from 240c601 to 0975a01 Compare January 29, 2025 18:06
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jan 29, 2025 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7b4cecd
Status: ✅  Deploy successful!
Preview URL: https://0ca9c0a2.pydantic-docs.pages.dev
Branch Preview URL: https://typealias-recursionerror.pydantic-docs.pages.dev

View logs

@Viicos Viicos force-pushed the typealias-recursionerror branch 2 times, most recently from 9df39e5 to 1f7a5f1 Compare January 29, 2025 19:57
@Viicos Viicos force-pushed the typealias-recursionerror branch from 1f7a5f1 to 3103c2f Compare January 29, 2025 20:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 29, 2025 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

sydney-runkle
sydney-runkle approved these changes Jan 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is helpful.

@Viicos Viicos enabled auto-merge (squash) February 1, 2025 10:27
@Viicos Viicos merged commit 54710a1 into main Feb 1, 2025
@Viicos Viicos deleted the typealias-recursionerror branch February 1, 2025 10:31
@ankit-kumar-meesho
Copy link
Copy Markdown

ankit-kumar-meesho commented Dec 8, 2025 •
edited
Loading

in which version was this released?

@Viicos
Copy link
Copy Markdown
Member Author

Viicos commented Dec 8, 2025

@ankit-kumar-meesho click on the commit link above (Viicos merged commit ...), you will see in which version it was merged below the commit message.

@ankit-kumar-meesho
Copy link
Copy Markdown

ankit-kumar-meesho commented Dec 8, 2025

2.12.5, thanks @Viicos

@ankit-kumar-meesho
Copy link
Copy Markdown

ankit-kumar-meesho commented Dec 8, 2025

but i am using this exact version and still facing issues when my flask application is trying to boot up. While loading confgs from env, pydantic is giving a lot of error with typing package. My changes are related to python 3.13

@Viicos
Copy link
Copy Markdown
Member Author

Viicos commented Dec 8, 2025

2.12.5

v2.11.0a2, the 2.12.5 version being shown is the latest tag.

but i am using this exact version and still facing issues when my flask application is trying to boot up. While loading confgs from env, pydantic is giving a lot of error with typing package. My changes are related to python 3.13

Please open a separate issue/discussion with a MRE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Milestone

No milestone

3 participants

@Viicos @ankit-kumar-meesho @sydney-runkle