Skip to content

Remove greenlet development dependency#11351

Merged
Viicos merged 1 commit intomainfrom
remove-greenlet
Jan 28, 2025
Merged

Remove greenlet development dependency#11351
Viicos merged 1 commit intomainfrom
remove-greenlet

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Jan 28, 2025

Change Summary

It is already required by sqlalchemy (and will not be anymore on sqlalchemy 2.1)

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Jan 28, 2025
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6805e76
Status: ✅  Deploy successful!
Preview URL: https://77b2616c.pydantic-docs.pages.dev
Branch Preview URL: https://remove-greenlet.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #11351 will not alter performance

Comparing remove-greenlet (6805e76) with main (5f40fe4)

Summary

✅ 45 untouched benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos merged commit 4722283 into main Jan 28, 2025
@Viicos Viicos deleted the remove-greenlet branch January 28, 2025 17:13
@Viicos Viicos added relnotes-packaging Used for dependency changes. and removed relnotes-fix Used for bugfixes. labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-packaging Used for dependency changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants