Skip to content

Add third-party tests for BeanieODM#11177

Merged
Viicos merged 9 commits intopydantic:mainfrom
mdaffad:ci/third-party-beanie
Dec 28, 2024
Merged

Add third-party tests for BeanieODM#11177
Viicos merged 9 commits intopydantic:mainfrom
mdaffad:ci/third-party-beanie

Conversation

@mdaffad
Copy link
Copy Markdown
Contributor

@mdaffad mdaffad commented Dec 24, 2024 •
edited
Loading

Change Summary

Integrate beanie tests on third party test workflow, part of third party tests on #11160.
Workflow result - https://github.com/mdaffad/pydantic/actions/runs/12477146497

Related issue number

#11160

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Dec 24, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 24, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #11177 will not alter performance

Comparing mdaffad:ci/third-party-beanie (7749fbf) with main (daa0732)

Summary

✅ 46 untouched benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 24, 2024 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

Viicos
Viicos requested changes Dec 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks great

Comment thread .github/workflows/third-party.yml Outdated
Comment thread .github/workflows/third-party.yml Outdated
Comment thread .github/workflows/third-party.yml Outdated
Comment thread .github/workflows/third-party.yml Outdated
Comment thread .github/workflows/third-party.yml Outdated
Comment thread .github/workflows/third-party.yml Outdated
@mdaffad mdaffad requested a review from Viicos December 25, 2024 04:12
@sydney-runkle sydney-runkle added the third-party-tests Add this label on a PR to trigger 3rd party tests label Dec 27, 2024
@sydney-runkle sydney-runkle removed the relnotes-fix Used for bugfixes. label Dec 27, 2024
sydney-runkle
sydney-runkle reviewed Dec 27, 2024
View reviewed changes
Comment thread .github/workflows/third-party.yml Outdated
@sydney-runkle sydney-runkle mentioned this pull request Dec 27, 2024
Open
16 tasks
@sydney-runkle
Copy link
Copy Markdown
Contributor

sydney-runkle commented Dec 27, 2024

LGTM, let's wait for @Viicos' approval before we merge :)

@Viicos Viicos changed the title ci: Third party test for beanie Add third-party tests for BeanieODM Dec 28, 2024
Viicos
Viicos approved these changes Dec 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Viicos Viicos merged commit 3294b9f into pydantic:main Dec 28, 2024
@mdaffad mdaffad deleted the ci/third-party-beanie branch December 28, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Viicos Viicos Viicos approved these changes

+1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

third-party-tests Add this label on a PR to trigger 3rd party tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdaffad @sydney-runkle @Viicos