Skip to content

Remove unused _extract_get_pydantic_json_schema() parameter#11155

Merged
sydney-runkle merged 1 commit intomainfrom
extract-get-pjs
Dec 19, 2024
Merged

Remove unused _extract_get_pydantic_json_schema() parameter#11155
sydney-runkle merged 1 commit intomainfrom
extract-get-pjs

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Dec 19, 2024

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Dec 19, 2024
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 169d3c5
Status: ✅  Deploy successful!
Preview URL: https://6d85c2de.pydantic-docs.pages.dev
Branch Preview URL: https://extract-get-pjs.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #11155 will improve performances by 5.28%

Comparing extract-get-pjs (169d3c5) with main (1f05976)

Summary

⚡ 1 improvements
✅ 45 untouched benchmarks

Benchmarks breakdown

Benchmark main extract-get-pjs Change
test_simple_model_validation[__init__] 42.4 µs 40.2 µs +5.28%

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Copy Markdown
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, thanks!

@sydney-runkle sydney-runkle merged commit 7485725 into main Dec 19, 2024
@sydney-runkle sydney-runkle deleted the extract-get-pjs branch December 19, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants