Skip to content

Do not resolve the JSON Schema reference for dict core schema keys#10989

Merged
sydney-runkle merged 1 commit intomainfrom
js-dict-keys-ref
Dec 2, 2024
Merged

Do not resolve the JSON Schema reference for dict core schema keys#10989
sydney-runkle merged 1 commit intomainfrom
js-dict-keys-ref

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Nov 27, 2024

The referenced schema might not be available yet.

Fixes #10960.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Nov 27, 2024
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Nov 27, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 75ddc34
Status: ✅  Deploy successful!
Preview URL: https://ca106d21.pydantic-docs.pages.dev
Branch Preview URL: https://js-dict-keys-ref.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #10989 will not alter performance

Comparing js-dict-keys-ref (75ddc34) with main (6f31f8f)

Summary

✅ 46 untouched benchmarks

The referenced schema might not be available yet.
@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  json_schema.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Copy Markdown
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix!

@sydney-runkle sydney-runkle merged commit dd95071 into main Dec 2, 2024
@sydney-runkle sydney-runkle deleted the js-dict-keys-ref branch December 2, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem generating OpenAPI schema for models with an enum as the key of a dict

2 participants