Conversation
Deploying pydantic-docs with
|
| Latest commit: |
88c495f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://37879cd6.pydantic-docs.pages.dev |
| Branch Preview URL: | https://10892.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10893 will not alter performanceComparing Summary
|
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
4d63e75 to
30f43fa
Compare
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Looking good, thanks for the docstring reorganization + additions.
Just one follow up question about parent frame fetching :)
sydney-runkle
approved these changes
Nov 21, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Nice work, thanks! Let's get this into v2.10.1
sydney-runkle
pushed a commit
that referenced
this pull request
Nov 22, 2024
…#10893) Move all the documentation into the class docstring, rewrite some small parts of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes #10892.
Also update some docstrings to explain better how frame fetching works.
Related issue number
Checklist