Make __signature__ a lazy property, do not deepcopy defaults#10818
Merged
Make __signature__ a lazy property, do not deepcopy defaults#10818
__signature__ a lazy property, do not deepcopy defaults#10818Conversation
Also follow stdlib dataclasses for signature parameter defaults. If a default factory is used, the placeholder `'<factory>'` is used.
Deploying pydantic-docs with
|
| Latest commit: |
fda5e91
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://232345cd.pydantic-docs.pages.dev |
| Branch Preview URL: | https://model-signature.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10818 will improve performances by 11.23%Comparing Summary
Benchmarks breakdown
|
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
This is promising - are there more class attributes for which we could do this? Gives us a nice boost on schema builds :)
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
sydney-runkle
approved these changes
Nov 13, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Very impressed with this implementation, good find.
Feel free to merge at your leisure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also follow stdlib dataclasses for signature parameter defaults. If a default factory is used, the placeholder
'<factory>'is used.Related issue number
Fixes #10771, #10656
Checklist