Skip to content

Ensure class access of method descriptors is performed when used as a default with Field#10816

Merged
sydney-runkle merged 1 commit intomainfrom
default-descriptor
Nov 11, 2024
Merged

Ensure class access of method descriptors is performed when used as a default with Field#10816
sydney-runkle merged 1 commit intomainfrom
default-descriptor

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Nov 11, 2024

Fixes #10551

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Nov 11, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #10816 will not alter performance

Comparing default-descriptor (81ae10d) with main (c7a3d5c)

Summary

✅ 44 untouched benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _fields.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Copy Markdown
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a pretty simple fix - thanks!

@sydney-runkle sydney-runkle merged commit 421c2fb into main Nov 11, 2024
@sydney-runkle sydney-runkle deleted the default-descriptor branch November 11, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: TypeError: cannot pickle 'staticmethod' object with a Field.default

2 participants