Skip to content

Fix stacklevel on deprecation warnings for BaseModel#10520

Merged
sydney-runkle merged 1 commit intomainfrom
stacklevel-fixes
Sep 30, 2024
Merged

Fix stacklevel on deprecation warnings for BaseModel#10520
sydney-runkle merged 1 commit intomainfrom
stacklevel-fixes

Conversation

@sydney-runkle
Copy link
Copy Markdown
Contributor

@sydney-runkle sydney-runkle commented Sep 30, 2024

Warnings now display when deprecated attributes are accessed :)

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Sep 30, 2024
@sydney-runkle sydney-runkle changed the title Fix stacklevels on deprecation warnings for BaseModel Fix stacklevel on deprecation warnings for BaseModel Sep 30, 2024
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4df96b3
Status: ✅  Deploy successful!
Preview URL: https://d755f03a.pydantic-docs.pages.dev
Branch Preview URL: https://stacklevel-fixes.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Sep 30, 2024

CodSpeed Performance Report

Merging #10520 will not alter performance

Comparing stacklevel-fixes (4df96b3) with main (01b5929)

Summary

✅ 38 untouched benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  main.py
Project Total  

This report was generated by python-coverage-comment-action

@sydney-runkle sydney-runkle merged commit 0327626 into main Sep 30, 2024
@sydney-runkle sydney-runkle deleted the stacklevel-fixes branch September 30, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants