@sydney-runkle , please review.

CodSpeed Performance Report

Merging #10374 will not alter performance

_{Comparing MovisLi:validate_call_patch (d152715) with main (8b6d5fc)}

Summary

✅ 49 untouched benchmarks

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic
validate_call_decorator.py
Project Total

This report was generated by python-coverage-comment-action

Looking good, could you please add a test as well? Thanks!

I don't quite understand what changes need to be made to the test cases. I add some codes to check if it is a coroutine the async function under decorator. Please check it, thank you!

I don't quite understand what changes need to be made to the test cases. I add some codes to check if it is a coroutine the async function under decorator. Please check it, thank you!

Something like:

import inspect

@validate_call
async def test():
    pass

assert inspect.iscoroutinefunction(test)

Happy to do another review here after we:

• revert formatting changes
• add a test like @Viicos sugested
• Move the function definitions into the conditional blocks, see below:

currently:

# function definitions

if condition:
    return func1
else:
    return func2

desired:

if condition:
    # define func1
    return func1
else:
    # define func2
    return func2

Thanks, great work here!

@Viicos @sydney-runkle I finish all @sydney-runkle mentioned. Please check it, thank you!