Skip to content

Do not error when trying to evaluate annotations of private attributes#10358

Merged
sydney-runkle merged 1 commit intomainfrom
10357
Sep 9, 2024
Merged

Do not error when trying to evaluate annotations of private attributes#10358
sydney-runkle merged 1 commit intomainfrom
10357

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Sep 9, 2024

Change Summary

Fixes #10357

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Sep 9, 2024
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 22c9e20
Status: ✅  Deploy successful!
Preview URL: https://8f134384.pydantic-docs.pages.dev
Branch Preview URL: https://10357.pydantic-docs.pages.dev

View logs

Copy link
Copy Markdown
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can include in a v2.9.2 release at the end of the week.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #10358 will not alter performance

Comparing 10357 (22c9e20) with main (fa79d93)

Summary

✅ 49 untouched benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 9, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _model_construction.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

from __future__ import annotations no longer works on v2.9.0

2 participants