Skip to content

Use correct types namespace when building namedtuple core schemas #10337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sydney-runkle merged 2 commits into from
Sep 6, 2024
Merged

Use correct types namespace when building namedtuple core schemas #10337

sydney-runkle merged 2 commits into from
Sep 6, 2024

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Sep 6, 2024 •
edited
Loading

Change Summary

Fixes #10336

Regression introduced in #10063

See diff without whitespaces

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 6, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 6, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 61ef3dd
Status: ✅  Deploy successful!
Preview URL: https://801cbc02.pydantic-docs.pages.dev
Branch Preview URL: https://10336.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 6, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10337 will not alter performance

Comparing 10336 (61ef3dd) with main (97d357f)

Summary

✅ 50 untouched benchmarks

sydney-runkle
sydney-runkle approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find @Viicos. Do we need to make any changed to typed dicts (I see we also changed that schema gen func in the original PR)

Feel free to remove that benchmark for now (let's comment it out), it's too flaky to be valuable at this point.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos
Copy link
Member Author

Viicos commented Sep 6, 2024

Do we need to make any changed to typed dicts

The types namespace stack is updated for typeddicts but wasn't for namedtuples, so this only affected the latter.

@Viicos
Copy link
Member Author

Viicos commented Sep 6, 2024

Feel free to remove that benchmark for now (let's comment it out), it's too flaky to be valuable at this point.

I have a pending PR that I'll finish this afternoon to tackle this

@sydney-runkle
Copy link
Contributor

sydney-runkle commented Sep 6, 2024

Sounds good. Also, could you please add a test before we merge?

sydney-runkle
sydney-runkle approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@sydney-runkle sydney-runkle merged commit c452c7e into main Sep 6, 2024
@sydney-runkle sydney-runkle deleted the 10336 branch September 6, 2024 12:04
sydney-runkle pushed a commit that referenced this pull request Sep 9, 2024
@Viicos @sydney-runkle
Use correct types namespace when building namedtuple core schemas (#1…
3d364cb 
…0337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong class namespace used when evaluating annotations of a NamedTuple

3 participants

@Viicos @sydney-runkle