Skip to content

Fix new warnings assertions to use pytest.warns()#10241

Merged
Viicos merged 1 commit intopydantic:mainfrom
mgorny:test-warn-assert
Aug 27, 2024
Merged

Fix new warnings assertions to use pytest.warns()#10241
Viicos merged 1 commit intopydantic:mainfrom
mgorny:test-warn-assert

Conversation

@mgorny
Copy link
Copy Markdown
Contributor

@mgorny mgorny commented Aug 27, 2024 •
edited by pydantic-hooky Bot
Loading

Change Summary

Fix new tests to use the correct pytest.warns() function to assert for warnings, rather than pytest.raises(). This fixes testing without -Werror.

Related issue number

n/a

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@mgorny
Fix new warnings assertions to use pytest.warns()
dd7ed4b 
Fix new tests to use the correct `pytest.warns()` function to assert
for warnings, rather than `pytest.raises()`.  This fixes testing
without `-Werror`.
@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Aug 27, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Aug 27, 2024

CodSpeed Performance Report

Merging #10241 will not alter performance

Comparing mgorny:test-warn-assert (dd7ed4b) with main (714c0df)

Summary

✅ 17 untouched benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 27, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@mgorny
Copy link
Copy Markdown
Contributor Author

mgorny commented Aug 27, 2024

please review

Viicos
Viicos approved these changes Aug 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@Viicos Viicos merged commit ed8df66 into pydantic:main Aug 27, 2024
@mgorny mgorny deleted the test-warn-assert branch August 27, 2024 07:41
@mgorny
Copy link
Copy Markdown
Contributor Author

mgorny commented Aug 27, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Viicos Viicos Viicos approved these changes

Assignees

@sydney-runkle sydney-runkle

Labels

ready for review relnotes-fix Used for bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgorny @Viicos @sydney-runkle