Update index.md in docs to import required things in code example#10229
Merged
Viicos merged 1 commit intopydantic:mainfrom Aug 25, 2024
Merged
Update index.md in docs to import required things in code example#10229Viicos merged 1 commit intopydantic:mainfrom
Viicos merged 1 commit intopydantic:mainfrom
Conversation
Imported 1. `datetime` from `datetime` 2. `PositiveInt` and `BaseModel` from `pydantic` Through it seems as this is not required as people will know it, Pydantic docs provides option to run examples which will result in error instead of the required behavior that the docs is trying to convey.
Contributor
Author
|
please review |
CodSpeed Performance ReportMerging #10229 will not alter performanceComparing Summary
|
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
1 task
Member
|
Thanks for the contribution. |
Viicos
approved these changes
Aug 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported
datetimefromdatetimePositiveIntandBaseModelfrompydanticChange Summary
Through it seems as this is not required as people will know it when reading docs, Pydantic docs provides option to run examples which will result in error instead of the required behavior that the docs is trying to convey.
Related issue number
Checklist
Selected Reviewer: @sydney-runkle