Fix ImportString special cases#10137
Merged
sydney-runkle merged 3 commits intomainfrom Aug 15, 2024
Merged
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
3c5e4a0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://49125506.pydantic-docs.pages.dev |
| Branch Preview URL: | https://test-import-string.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10137 will not alter performanceComparing Summary
|
Viicos
approved these changes
Aug 14, 2024
Comment on lines
+1016
to
+1017
| # Handle special cases for sys.XXX streams | ||
| # if we see more of these, we should consider a more general solution |
Member
There was a problem hiding this comment.
I think in general serializing the imported object to a string is a hard (even impossible without special casing as it is done here) problem, so I'm fine with the proposed solution.
Contributor
Author
There was a problem hiding this comment.
Cool, thanks!
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #10122
I can understand the argument for a more general solution, but I wasn't able to find an easy workaround for io wrappers. Feedback welcome!