Update serialization warning tests with faulty values#10085
Merged
sydney-runkle merged 2 commits intomainfrom Aug 12, 2024
Merged
Update serialization warning tests with faulty values#10085sydney-runkle merged 2 commits intomainfrom
sydney-runkle merged 2 commits intomainfrom
Conversation
CodSpeed Performance ReportMerging #10085 will not alter performanceComparing Summary
|
sydney-runkle
suggested changes
Aug 8, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Looks great - let's mark these tests with @pytest.mark.xfail(reason='blah blah blah') with a reason explaining that these will pass once we use the next pydantic-core version :).
Deploying pydantic-docs with
|
| Latest commit: |
4d7ea73
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ece2a7f.pydantic-docs.pages.dev |
| Branch Preview URL: | https://boxy-ser-warning-change.pydantic-docs.pages.dev |
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
sydney-runkle
approved these changes
Aug 12, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Nice work @BoxyUwU, first contribution to pydantic!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pydantic/pydantic-core#1377 the warning when providing a wrongly typed value for serialization was changed. This PR updates pydantic's tests to check for the new warning
cc @sydney-runkle