Remove logic to handle unused __get_pydantic_core_schema__ signature#10075
Merged
Remove logic to handle unused __get_pydantic_core_schema__ signature#10075
__get_pydantic_core_schema__ signature#10075Conversation
This was introduced in #5490, but doesn't seem to be used.
Deploying pydantic-docs with
|
| Latest commit: |
8629333
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88f2c045.pydantic-docs.pages.dev |
| Branch Preview URL: | https://unused-get-schema-format.pydantic-docs.pages.dev |
adriangb
approved these changes
Aug 7, 2024
Member
adriangb
left a comment
There was a problem hiding this comment.
👍🏻 we can always add it back...
CodSpeed Performance ReportMerging #10075 will not alter performanceComparing Summary
|
Member
Author
This seems to be the only code path allowing such a signature anyway :) |
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in #5490, but doesn't seem to be used.
Change Summary
Related issue number
Checklist