Refactor application of deque annotations#10018
Merged
sydney-runkle merged 3 commits intomainfrom Aug 1, 2024
Merged
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
9d8ea16
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fe9eb7f7.pydantic-docs.pages.dev |
| Branch Preview URL: | https://deq-refac.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10018 will not alter performanceComparing Summary
|
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
adriangb
approved these changes
Aug 1, 2024
| @@ -0,0 +1,49 @@ | |||
| import collections | |||
Member
There was a problem hiding this comment.
I feel like we should have from __future__ import annotations everywhere here
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9340
Simplify the injection of annotations for deque types. Calling this the end of the sequence validator refactor - we've restructured significantly, and I think the next step is moving things to
pydantic-core, which wasn't within the original scope of the issue.