Only check DH key validity when loading a private key.#9071
Merged
reaperhulk merged 1 commit intopyca:mainfrom Jun 17, 2023
Merged
Only check DH key validity when loading a private key.#9071reaperhulk merged 1 commit intopyca:mainfrom
reaperhulk merged 1 commit intopyca:mainfrom
Conversation
reaperhulk
approved these changes
Jun 17, 2023
Member
reaperhulk
left a comment
There was a problem hiding this comment.
This returns us to pre-rust behavior. Checking the key is safer but check cost is very high (two Miller-Rabin primality checks + a modexp). Future folks should consider whether we want to do an unsafe load kwarg like we do for RSA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9063