Conversation
@Yossarian pointed out that we missed this breaking change #12110
Member
Author
|
We should probably backport this to 45.0.x as well so that any subsequent 45.0.x releases have the corrected changelog. |
Member
|
We're calling this backwards incompatible because external implementers need to add it? I don't think we've historically documented additions this way -- I'm happy to add it, but I"m not wild about the bold BACKWARDS INCOMPATIBLE. We did all the ABCs right, not just RSA? |
Member
Author
|
We did add it to all keys. I'm okay with saying we should document this without the BACKWARDS INCOMPATIBLE, although any time we add to an ABC we are going to break external implementations and we even document how to do this type of external implementation now 😄 |
Member
|
👍 |
alex
approved these changes
May 19, 2025
alex
pushed a commit
to alex/cryptography
that referenced
this pull request
May 25, 2025
* add missing 45.0.0 changelog entry @Yossarian pointed out that we missed this breaking change pyca#12110 * Update CHANGELOG.rst * oops
reaperhulk
added a commit
that referenced
this pull request
May 25, 2025
* Rename PBES1 types to better match their origins in the spec (#12976) PBEParams is defined in RFC 8018 as going with PBES1, but then its also used by PKCS#12 ciphers in RFC 7292. * add vector and test for longer salt length in PBE (#12977) * add vector and test for longer salt length in PBE * Update docs/development/test-vectors.rst Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com> --------- Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com> * fixes #12949 -- added support for decrypting des-cbc-md5 keys (#12978) * add missing 45.0.0 changelog entry (#12946) * add missing 45.0.0 changelog entry @Yossarian pointed out that we missed this breaking change #12110 * Update CHANGELOG.rst * oops * changelog + version bump * add pbeWithMD5AndDES-CBC test vector (#12956) * typo * fix documentation for the decrepit algorithms module (#12953) --------- Co-authored-by: Paul Kehrer <paul.l.kehrer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Yossarian pointed out that we missed this breaking change #12110