Conversation
|
Test PASSed. |
There was a problem hiding this comment.
Will comments in this style make Windows compiler mad?
There was a problem hiding this comment.
It doesn't look like they do based on the passing Jenkins tests but maybe we should change that to /* */ anyway...
On Sat, Jun 21, 2014 at 6:35 PM, Alex Gaynor notifications@github.com
wrote:
@@ -165,6 +181,11 @@
"""MACROS = """
+// X509_STORE_CTXWill comments in this style make Windows compiler mad?
Reply to this email directly or view it on GitHub:
https://github.com/pyca/cryptography/pull/1161/files#r14052385
There was a problem hiding this comment.
Interestingly I think some of those comments started as /**/ and then I changed them because some other comments were // already :)
There was a problem hiding this comment.
(I suppose what I'm trying to say is that a wider // -> /**/ may be in order, and, if this doesn't make the buildbotses unhappy, that can happen on a separate PR)
There was a problem hiding this comment.
Agreed on comment changes being a separate PR. That makes this one merge ready then!
On Sun, Jun 22, 2014 at 12:18 AM, Laurens Van Houtven
notifications@github.com wrote:
@@ -165,6 +181,11 @@
"""MACROS = """
+// X509_STORE_CTX(I suppose what I'm trying to say is that a wider
//->/**/may be in order, and, if this doesn't make the buildbotses unhappy, that can happen on a separate PR)Reply to this email directly or view it on GitHub:
https://github.com/pyca/cryptography/pull/1161/files#r14053169
Builds on @lvh's work in #1156. Let's see if jenkins is okay with it.