Skip to content

Conversation

@ax3l
Copy link
Collaborator

@ax3l ax3l commented Jun 24, 2018

builds against a python debug library were unreliable and could lead to symbol errors during linking.

Setting the Py_DEBUG define is necessary when linking against a debug build:

https://stackoverflow.com/questions/39161202/how-to-work-around-missing-pymodule-create2-in-amd64-win-python35-d-lib

https://docs.python.org/2/c-api/intro.html#debugging-builds

https://docs.python.org/3.6/c-api/intro.html#debugging-builds

First seen in PR #1416

builds against a python debug library were unreliable and
could lead to symbol errors during linking.

Setting the `Py_DEBUG` define is necessary when linking
against a debug build:

https://stackoverflow.com/questions/39161202/how-to-work-around-missing-pymodule-create2-in-amd64-win-python35-d-lib

https://docs.python.org/2/c-api/intro.html#debugging-builds

https://docs.python.org/3.6/c-api/intro.html#debugging-builds
@ax3l ax3l force-pushed the fix-pyDebugLibs branch from 1d0eb82 to c1d894d Compare June 24, 2018 14:06
@ax3l
Copy link
Collaborator Author

ax3l commented Aug 8, 2018

@wjakob @jagerman this PR fixes failing debug builds where the wrong Python ABI is selected. Can you please take a look?

@ax3l
Copy link
Collaborator Author

ax3l commented Aug 29, 2018

@wjakob do you mind merging this as well? :)

@wjakob
Copy link
Member

wjakob commented Aug 29, 2018

Yeah, sorry about the delay.

@wjakob wjakob merged commit 3a94561 into pybind:master Aug 29, 2018
@ax3l ax3l deleted the fix-pyDebugLibs branch August 29, 2018 11:22
@ax3l
Copy link
Collaborator Author

ax3l commented Aug 29, 2018

no prob, thanks a lot!

@ax3l ax3l mentioned this pull request Sep 4, 2018
wjakob pushed a commit that referenced this pull request Sep 11, 2018
builds against a python debug library were unreliable and
could lead to symbol errors during linking.

Setting the `Py_DEBUG` define is necessary when linking
against a debug build:

https://stackoverflow.com/questions/39161202/how-to-work-around-missing-pymodule-create2-in-amd64-win-python35-d-lib

https://docs.python.org/2/c-api/intro.html#debugging-builds

https://docs.python.org/3.6/c-api/intro.html#debugging-builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants