BUG: Adobe Acrobat 'Would you like to save this file?'#970
Merged
MartinThoma merged 1 commit intomainfrom Jun 11, 2022
Merged
Conversation
Issue: When creating files with the current PpdfWriter,
Adobe Acrobat asks 'would you like to save this file'
when attempting to close it - although no changes were made.
Fix: Remove 'self.set_need_appearances_writer()' from writers
__init__ function
Closes# 963
Codecov Report
@@ Coverage Diff @@
## main #970 +/- ##
=======================================
Coverage 84.26% 84.26%
=======================================
Files 18 18
Lines 4117 4117
Branches 868 868
=======================================
Hits 3469 3469
Misses 465 465
Partials 183 183
Continue to review full report at Codecov.
|
Collaborator
MartinThoma
added a commit
that referenced
this pull request
Jun 12, 2022
New Features (ENH): - Add support for pathlib as input for PdfReader (#979) Performance Improvements (PI): - Optimize read_next_end_line (#646) Bug Fixes (BUG): - Adobe Acrobat \'Would you like to save this file?\' (#970) Documentation (DOC): - Notes on annotations (#982) - Who uses PyPDF2 - intendet \xe2\x9e\x94 in robustness page (#958) Maintenance (MAINT): - pre-commit / requirements.txt updates (#977) - Mark read_next_end_line as deprecated (#965) - Export `PageObject` in PyPDF2 root (#960) Testing (TST): - Add MCVE of issue #416 (#980) - FlateDecode.decode decodeParms (#964) - Xmp module (#962) - utils.paeth_predictor (#959) Code Style (STY): - Use more tuples and list/dict comprehensions (#976) Full Changelog: 2.1.0...2.1.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: When creating files with the current PpdfWriter,
Adobe Acrobat asks 'would you like to save this file'
when attempting to close it - although no changes were made.
Fix: Remove 'self.set_need_appearances_writer()' from writers
__init__functionCloses #963