BUG: Fix XmpInformation missing method _getText#915
Conversation
Codecov Report
@@ Coverage Diff @@
## main #915 +/- ##
=======================================
Coverage 77.89% 77.89%
=======================================
Files 16 16
Lines 4324 4324
Branches 813 813
=======================================
Hits 3368 3368
Misses 784 784
Partials 172 172
Continue to review full report at Codecov.
|
|
Hi, I'm using Github's submission Issues feature for the first time, I was wondering if this bug fix can be fixed until you merge into the main branch and I install the new version again? |
|
Thank you for the fix! I'll merge + fix it on the 1.x branch. I don't understand yet why mypy didn't capture those 🕵️ |
I used |
Sorry, I don't understand that. Are you asking if there is a way to install from the feature branch? As the fix was already released, it's no longer necessary. It is possible to install from git (and also from specific branches), but I would need to look the exact syntax/urls up. Might be a good idea to add this to the documentation, although it's rather a pip question than a PyPDF2 question 🤔 |
|
#918 enables mypy / makes this type of mistake impossible (preventing a regression + ensuring we captured all; at least for the PyPDF2 2.0.0 release) |
Fixes #914 (though will want to backport)
PR fixes a bug where some methods in the
xmpmodule were referencing the old name of internal functions (_getText) instead of the new version (_get_text).I suppose this would be an argument to move to only supporting Python 3.7 so that can use forward references for type annotations, so that could do
self: XmpInformationthroughout these to allow mypy to help catch these sorts of errors.