Merged
Conversation
* getXmpMetadata / xmpMetadata
Codecov Report
@@ Coverage Diff @@
## main #900 +/- ##
==========================================
- Coverage 78.55% 77.90% -0.66%
==========================================
Files 16 16
Lines 4258 4317 +59
Branches 813 813
==========================================
+ Hits 3345 3363 +18
- Misses 738 780 +42
+ Partials 175 174 -1
Continue to review full report at Codecov.
|
Member
Author
|
I was curious if some of those attributes were actually used:
|
Member
Author
|
rotate_clockwise -> just rotate? Pro
Pro
Other:
|
MasterOdin
reviewed
May 25, 2022
MartinThoma
added a commit
that referenced
this pull request
May 26, 2022
* getXmpMetadata / xmpMetadata ➔ xmp_metadata * get_outlines ➔ _get_outlines (use outlines property instead) * getXmpMetadata ➔ xmp_metadata * getDestArray ➔ dest_array * additionalActions ➔ additional_actions * defaultValue ➔ default_value * mappingName ➔ mapping_name * altName ➔ alternate_name * fieldType ➔ field_type * ensureIsNumber ➔ _ensure_is_number * decodedSelf : decoded_self * addChild / removeChild ➔ add_child / remove_child * flateEncode ➔ flate_encode * getData / setData ➔ get_data / set_data See #900
Merged
MartinThoma
added a commit
that referenced
this pull request
May 26, 2022
* getXmpMetadata / xmpMetadata ➔ xmp_metadata * get_outlines ➔ _get_outlines (use outlines property instead) * getXmpMetadata ➔ xmp_metadata * getDestArray ➔ dest_array * additionalActions ➔ additional_actions * defaultValue ➔ default_value * mappingName ➔ mapping_name * altName ➔ alternate_name * fieldType ➔ field_type * ensureIsNumber ➔ _ensure_is_number * decodedSelf : decoded_self * addChild / removeChild ➔ add_child / remove_child * flateEncode ➔ flate_encode * getData / setData ➔ get_data / set_data See #900
MartinThoma
added a commit
that referenced
this pull request
May 26, 2022
* getXmpMetadata / xmpMetadata ➔ xmp_metadata * get_outlines ➔ _get_outlines (use outlines property instead) * getXmpMetadata ➔ xmp_metadata * getDestArray ➔ dest_array * additionalActions ➔ additional_actions * defaultValue ➔ default_value * mappingName ➔ mapping_name * altName ➔ alternate_name * fieldType ➔ field_type * ensureIsNumber ➔ _ensure_is_number * decodedSelf : decoded_self * addChild / removeChild ➔ add_child / remove_child * flateEncode ➔ flate_encode * getData / setData ➔ get_data / set_data See #900
MartinThoma
added a commit
that referenced
this pull request
May 26, 2022
* getXmpMetadata / xmpMetadata ➔ xmp_metadata * get_outlines ➔ _get_outlines (use outlines property instead) * getXmpMetadata ➔ xmp_metadata * getDestArray ➔ dest_array * additionalActions ➔ additional_actions * defaultValue ➔ default_value * mappingName ➔ mapping_name * altName ➔ alternate_name * fieldType ➔ field_type * ensureIsNumber ➔ _ensure_is_number * decodedSelf : decoded_self * addChild / removeChild ➔ add_child / remove_child * flateEncode ➔ flate_encode * getData / setData ➔ get_data / set_data See #900
MartinThoma
added a commit
that referenced
this pull request
May 26, 2022
PdfReader: * getXmpMetadata / xmpMetadata ➔ xmp_metadata * get_outlines ➔ _get_outlines (use outlines property instead) Field attributes: * additionalActions ➔ additional_actions * defaultValue ➔ default_value * mappingName ➔ mapping_name * altName ➔ alternate_name * fieldType ➔ field_type StreamObject: * decodedSelf : decoded_self * flateEncode ➔ flate_encode Other: * Destination: getDestArray ➔ dest_array * RectangleObject: ensureIsNumber ➔ _ensure_is_number * TreeObject: addChild / removeChild ➔ add_child / remove_child * DecodedStreamObject: getData / setData ➔ get_data / set_data See #900
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyPDF2 interface changes:
DOC: Use the new PyPDF2 interface
STY: Use reader/writer as variable names for PdfReader / PdfWriter