Skip to content

DEP: overwriteWarnings parameter of reader/merger#846

Merged
MartinThoma merged 1 commit into2.0.0-devfrom
drop-overwrite-warnings
May 1, 2022
Merged

DEP: overwriteWarnings parameter of reader/merger#846
MartinThoma merged 1 commit into2.0.0-devfrom
drop-overwrite-warnings

Conversation

@MartinThoma
Copy link
Copy Markdown
Member

PdfFileReader and PdfFileMerger no longer have the overwriteWarnings.
The new behavior is overwriteWarnings=False.

Additionally, PyPDF2.utils.formatWarning was removed

PdfFileReader and PdfFileMerger no longer have the `overwriteWarnings`.
The new behavior is `overwriteWarnings=False`.
Additionally, PyPDF2.utils.formatWarning was removed
@MartinThoma MartinThoma force-pushed the drop-overwrite-warnings branch from 1882178 to 1503b95 Compare May 1, 2022 11:53
@codecov
Copy link
Copy Markdown

codecov bot commented May 1, 2022

Codecov Report

Merging #846 (1503b95) into 2.0.0-dev (a55c01d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           2.0.0-dev     #846      +/-   ##
=============================================
+ Coverage      82.07%   82.11%   +0.04%     
=============================================
  Files             15       15              
  Lines           3649     3635      -14     
  Branches         780      777       -3     
=============================================
- Hits            2995     2985      -10     
+ Misses           489      487       -2     
+ Partials         165      163       -2     
Impacted Files Coverage Δ
PyPDF2/utils.py 91.72% <ø> (-0.19%) ⬇️
PyPDF2/_reader.py 81.42% <100.00%> (+0.27%) ⬆️
PyPDF2/merger.py 66.77% <100.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a55c01d...1503b95. Read the comment docs.

@MartinThoma MartinThoma merged commit b5e0ee2 into 2.0.0-dev May 1, 2022
@MartinThoma MartinThoma deleted the drop-overwrite-warnings branch May 1, 2022 11:56
MartinThoma added a commit that referenced this pull request May 2, 2022
PdfFileReader and PdfFileMerger no longer have the `overwriteWarnings`.
The new behavior is `overwriteWarnings=False`.

Additionally, PyPDF2.utils.formatWarning was removed
MartinThoma added a commit that referenced this pull request May 2, 2022
PdfFileReader and PdfFileMerger no longer have the `overwriteWarnings`.
The new behavior is `overwriteWarnings=False`.

Additionally, PyPDF2.utils.formatWarning was removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant