fix issues with missing destinations (#604)#840
Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom Apr 30, 2022
Merged
Conversation
py-pdf#604 root cause: probably extraction from a document not extracting properly destination changes: getDestinationPageNumber return -1 with NullObject in case of Strict = False, return a destination to first page to prevent error (no change in case of Strict=True) note ; warning generated Test added with the sample test (duplicate of py-pdf#821 to match refactoring)
Codecov Report
@@ Coverage Diff @@
## main #840 +/- ##
==========================================
+ Coverage 81.65% 81.79% +0.14%
==========================================
Files 16 16
Lines 3695 3703 +8
Branches 801 803 +2
==========================================
+ Hits 3017 3029 +12
+ Misses 502 499 -3
+ Partials 176 175 -1
Continue to review full report at Codecov.
|
MartinThoma
added a commit
that referenced
this pull request
May 1, 2022
Robustness (ROB): - Handle missing destinations in reader (#840) - warn-only in readStringFromStream (#837) - Fix corruption in startxref or xref table (#788 and #830) Documentation (DOC): - Project Governance (#799) - History of PyPDF2 - PDF feature/version support (#816) - More details on text parsing issues (#815) Developer Experience (DEV): - Add benchmark command to Makefile - Ignore IronPython parts for code coverage (#826) Maintenance (MAINT): - Split pdf module (#836) - Separated CCITTFax param parsing/decoding (#841) - Update requirements files Testing (TST): - Use external repository for larger/more PDFs for testing (#820) - Swap incorrect test names (#838) - Add test for PdfFileReader and page properties (#835) - Add tests for PyPDF2.generic (#831) - Add tests for utils, form fields, PageRange (#827) - Add test for ASCII85Decode (#825) - Add test for FlateDecode (#823) - Add test for filters.ASCIIHexDecode (#822) Code Style (STY): - Apply pre-commit (black, isort) + use snake_case variables (#832) - Remove debug code (#828) - Documentation, Variable names (#839) Full Changelog: 1.27.9...1.27.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#604
root cause: probably extraction from a document not extracting properly destination
changes:
Test added with the sample test
(duplicate of #821 to match refactoring)