Skip to content

[Breaking Change] MAINT: Remove OutlinesObject#829

Closed
MartinThoma wants to merge 1 commit intomainfrom
remove-outlines-class
Closed

[Breaking Change] MAINT: Remove OutlinesObject#829
MartinThoma wants to merge 1 commit intomainfrom
remove-outlines-class

Conversation

@MartinThoma
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 27, 2022

Codecov Report

Merging #829 (79ab79f) into main (35086b6) will increase coverage by 1.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
+ Coverage   77.25%   78.79%   +1.54%     
==========================================
  Files          12       12              
  Lines        3486     3410      -76     
  Branches      817      803      -14     
==========================================
- Hits         2693     2687       -6     
+ Misses        580      510      -70     
  Partials      213      213              
Impacted Files Coverage Δ
PyPDF2/generic.py 72.88% <ø> (+5.35%) ⬆️
PyPDF2/merger.py 71.83% <ø> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35086b6...79ab79f. Read the comment docs.

@MartinThoma
Copy link
Copy Markdown
Member Author

@MasterOdin Are you aware of what this is/was used for? Do users need it?

Before I merge this PR + relase it, I would add a deprecation warning. It would only be removed with a major version bump.

@MartinThoma MartinThoma changed the title MAINT: Remove OutlinesObject [Breaking Change] MAINT: Remove OutlinesObject Apr 27, 2022
@MartinThoma MartinThoma added this to the PyPDF2 version 2.0.0 milestone Apr 27, 2022
@MartinThoma MartinThoma closed this May 1, 2022
MartinThoma added a commit that referenced this pull request May 1, 2022
MartinThoma added a commit that referenced this pull request May 2, 2022
MartinThoma added a commit that referenced this pull request May 2, 2022
@MartinThoma MartinThoma deleted the remove-outlines-class branch May 26, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant