Skip to content

STY: Use PEP8-style function names and magic methods#759

Closed
MartinThoma wants to merge 2 commits intomainfrom
magic
Closed

STY: Use PEP8-style function names and magic methods#759
MartinThoma wants to merge 2 commits intomainfrom
magic

Conversation

@MartinThoma
Copy link
Copy Markdown
Member

@MartinThoma MartinThoma commented Apr 15, 2022

See #751 - Magic Methods
See #752 - PEP8 names

@MartinThoma
STY: Use PEP8-style function names and magic methods
492af64 
See #751 - Magic Methods
See #752 - PEP8 names
  - also #684
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 15, 2022 •
edited
Loading

Codecov Report

Merging #759 (66f9ac9) into main (9111336) will increase coverage by 0.03%.
The diff coverage is 83.78%.

@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   73.92%   73.96%   +0.03%     
==========================================
  Files          11       11              
  Lines        3490     3518      +28     
  Branches      811      815       +4     
==========================================
+ Hits         2580     2602      +22     
- Misses        676      679       +3     
- Partials      234      237       +3
Impacted Files Coverage Δ
PyPDF2/pagerange.py 90.62% <50.00%> (-9.38%) ⬇️
PyPDF2/pdf.py 79.28% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9111336...66f9ac9. Read the comment docs.

@MartinThoma
Copy link
Copy Markdown
Member Author

MartinThoma commented Apr 17, 2022

TODO: RectangleObject needs properties!

MartinThoma added a commit that referenced this pull request Jun 6, 2022
@MartinThoma
ENH: Allow adding PageRange objects
6c5d0ab 
Now the following is possible:

    >>> from PyPDF2 import PageRange
    >>> a = PageRange("0:5")
    >>> b = PageRange("2:7")
    >>> a + b
    PageRange("0:7")

Closes #759
See #751
See #752
@MartinThoma MartinThoma mentioned this pull request Jun 6, 2022
Merged
MartinThoma added a commit that referenced this pull request Jun 6, 2022
@MartinThoma
ENH: Allow adding PageRange objects
fc822e1 
Now the following is possible:

    >>> from PyPDF2 import PageRange
    >>> a = PageRange("0:5")
    >>> b = PageRange("2:7")
    >>> a + b
    PageRange("0:7")

Closes #759
See #751
See #752
MartinThoma added a commit that referenced this pull request Jun 6, 2022
@MartinThoma
ENH: Allow adding PageRange objects
30d8f3e 
Now the following is possible:

    >>> from PyPDF2 import PageRange
    >>> a = PageRange("0:5")
    >>> b = PageRange("2:7")
    >>> a + b
    PageRange("0:7")

Closes #759
See #751
See #752
MartinThoma added a commit that referenced this pull request Jun 6, 2022
@MartinThoma
ENH: Allow adding PageRange objects (#948)
2a1db78 
Now the following is possible:

    >>> from PyPDF2 import PageRange
    >>> a = PageRange("0:5")
    >>> b = PageRange("2:7")
    >>> a + b
    PageRange("0:7")

Closes #759
See #751
See #752
@MartinThoma MartinThoma deleted the magic branch June 11, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MartinThoma @codecov-commenter