Filename issue in formatWarning method in utils.py#641
Closed
louisgregg wants to merge 2 commits intopy-pdf:masterfrom
Closed
Filename issue in formatWarning method in utils.py#641louisgregg wants to merge 2 commits intopy-pdf:masterfrom
louisgregg wants to merge 2 commits intopy-pdf:masterfrom
Conversation
mlissner
added a commit
to freelawproject/courtlistener
that referenced
this pull request
Mar 23, 2022
In the following issues and PRs, PyPDF2 users have identified and offered to fix a weird bug where the library overrides normal logging in a way that breaks when you log certain things: py-pdf/pypdf#67 py-pdf/pypdf#641 py-pdf/pypdf#452 py-pdf/pypdf#243 Not great, but there was probably a reason. Unfortunately, the maintainers aren't merging any of the fixes people have provided over the years, and when I upgraded to Python 3.10 one of our tests changed in a way that it triggered this bug. So, since the maintainers don't seem inclined to fix their own package, this commit yanks it from CourtListener. It's good timing, really, since we now have the microservice available, but it was disappointing to see bugs and PRs related to this going back to 2014. Most of the fixes are one or two-line PRs too. Bummer.
Member
|
Thank you for your contribution! This issue was fixed in another PR which I just merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have created a pull request to address the
IndexErrorwhich arises whenformatWarning()in utils.py is passed afilenamestring that doesn't contain a/or\\character. I simply implemented @CrimsonZen's suggestion of replacing:file = filename.replace("/","\\").rsplit("\\",1)[1] # find the file namewith
file = filename.replace("/","\\").rsplit("\\",1).pop() # find the file nameHopefully this can be merged into the main branch at some point. This error arises because PyPDF2 overwrites
warnings.formatwarning(issue #67). However, this pull request does not address the issue directly.