Fix 608 use null ID when encrypted but no ID given#610
Closed
richardmillson wants to merge 2 commits intopy-pdf:mainfrom
richardmillson:fix-608-decryption-fails-when-no-ID-in-trailer
Closed
Fix 608 use null ID when encrypted but no ID given#610richardmillson wants to merge 2 commits intopy-pdf:mainfrom richardmillson:fix-608-decryption-fails-when-no-ID-in-trailer
richardmillson wants to merge 2 commits intopy-pdf:mainfrom
richardmillson:fix-608-decryption-fails-when-no-ID-in-trailer
Conversation
Member
|
Thank you for your PR! It already looks good, but it has merge conflicts. Would you mind resolving them? If you don't want to do that, I would take care of it. I would give credit via Githubs co-authored-by feature. |
MartinThoma
added a commit
that referenced
this pull request
Apr 24, 2022
If no '/ID' key is present in self.trailer an array of two empty bytestrings is used in place of an '/ID'. This is how Apache PDFBox handles this case. This makes PyPDF2 more robust to malformed PDFs. Closes #608 Closes #610 Full credit for this one to Richard Millson - Martin Thoma only fixed a merge conflict Co-authored-by: Richard Millson <8217613+richardmillson@users.noreply.github.com>
VictorCarlquist
pushed a commit
to VictorCarlquist/PyPDF2
that referenced
this pull request
Apr 29, 2022
If no '/ID' key is present in self.trailer an array of two empty bytestrings is used in place of an '/ID'. This is how Apache PDFBox handles this case. This makes PyPDF2 more robust to malformed PDFs. Closes py-pdf#608 Closes py-pdf#610 Full credit for this one to Richard Millson - Martin Thoma only fixed a merge conflict Co-authored-by: Richard Millson <8217613+richardmillson@users.noreply.github.com>
Contributor
Author
|
@MartinThoma Didn't see your message in time; thanks for resolving the conflict and merging though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
self.trailerthrows a KeyError and is not decrypted.self.traileran array of two empty bytestringsis used in place of an '/ID'. This is how Apache PDFBox handles this case.
don't follow the spec.
uses this library, this provides a branch with working behavior to use.
How Has This Been Tested?