Skip to content

Docs/Samples#574

Closed
polyglot-jones wants to merge 4 commits intopy-pdf:mainfrom
polyglot-jones:docs-samples
Closed

Docs/Samples#574
polyglot-jones wants to merge 4 commits intopy-pdf:mainfrom
polyglot-jones:docs-samples

Conversation

@polyglot-jones
Copy link
Copy Markdown
Contributor

The big-ticket item in this PR is that I got PyPDF2 to correctly fill in the text fields of a PDF form and make them visible for printing. This required a few modifications to PdfFileWriter. (See the comments for where I gave credit to the dude on Stackoverflow with the solution.)

  • Added sample code for filling in the text fields of a PDF form. (FYI: The example fillable_form.pdf was created in LibreOffice from the enclosed fillable_form.odt.)
  • Annotated the other sample code (incl. renaming them to be consistent snake_case).
  • Changed the README in the Sample Code folder from txt to markdown, and expanded on it.
  • Fixed a syntax error in Sample_Code/basic_features.py

NOTE: In the new Sample_Code/fillable_fields.py, I couldn't get it to repeat, generating a second filled-in PDF with different data. Someone with more knowledge of the internals needs to see the FIXME comment I added at the end.

polyglot-jones and others added 4 commits August 10, 2020 15:11
This required a few modifications to PdfFileWriter.
(FYI: The example `fillable_form.pdf` was created in LibreOffice from the enclosed `fillable_form.odt`.)
@MartinThoma MartinThoma added the nf-documentation Non-functional change: Documentation label Apr 16, 2022
@MartinThoma
Copy link
Copy Markdown
Member

I'm sorry that it took so long. Would you mind resolving the merge conflicts?

@MartinThoma MartinThoma added the needs-change The PR/issue cannot be handled as issue and needs to be improved label Apr 16, 2022
@MartinThoma
Copy link
Copy Markdown
Member

have_viewer_render_fields is not necessary as set_need_appearances_writer exists.

MartinThoma added a commit that referenced this pull request Apr 23, 2022
Closes #574
Closes #801

Co-authored-by: Craig Jones <craig@k6nnl.com>
MartinThoma added a commit that referenced this pull request Apr 23, 2022
Closes #574
Closes #801

Co-authored-by: Craig Jones <craig@k6nnl.com>
VictorCarlquist pushed a commit to VictorCarlquist/PyPDF2 that referenced this pull request Apr 29, 2022
Closes py-pdf#574
Closes py-pdf#801

Co-authored-by: Craig Jones <craig@k6nnl.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-change The PR/issue cannot be handled as issue and needs to be improved nf-documentation Non-functional change: Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants