Skip to content

ENH: Add code to extract XML form data from Adobe ES4 PDF forms#408

Closed
georgealverson wants to merge 4 commits intopy-pdf:mainfrom
georgealverson:master
Closed

ENH: Add code to extract XML form data from Adobe ES4 PDF forms#408
georgealverson wants to merge 4 commits intopy-pdf:mainfrom
georgealverson:master

Conversation

@georgealverson
Copy link
Copy Markdown
Contributor

@georgealverson georgealverson commented Mar 19, 2018

No description provided.

@MartinThoma MartinThoma added the Tiny Pull requests that make a tiny change - and thus should be easy to merge label Apr 6, 2022
MartinThoma
MartinThoma reviewed Apr 16, 2022
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #408 (8f4b1e0) into main (733989a) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

❗ Current head 8f4b1e0 differs from pull request most recent head fd5f212. Consider uploading reports for the commit fd5f212 to get more accurate results

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   69.57%   69.40%   -0.17%     
==========================================
  Files           9        9              
  Lines        3316     3324       +8     
  Branches      783      786       +3     
==========================================
  Hits         2307     2307              
- Misses        766      774       +8     
  Partials      243      243
Impacted Files Coverage Δ
PyPDF2/pdf.py 72.00% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 733989a...fd5f212. Read the comment docs.

@MartinThoma
Copy link
Copy Markdown
Member

MartinThoma commented Apr 16, 2022

@georgealverson Do you have an example PDF which we could use in the unit tests?

@MartinThoma MartinThoma added the needs-test A test should be added before this PR is merged. label Apr 16, 2022
@georgealverson
Copy link
Copy Markdown
Contributor Author

georgealverson commented Apr 18, 2022 via email

@MartinThoma
Copy link
Copy Markdown
Member

MartinThoma commented Apr 18, 2022

Please either send it to info@martin-thoma.de or upload it directly on github. I cannot see an attachment here. I guess github filters it

@georgealverson
Copy link
Copy Markdown
Contributor Author

georgealverson commented Apr 18, 2022

PyPDF_test_file.pdf
This is the file that was stripped

MartinThoma
MartinThoma reviewed Jun 25, 2022
View reviewed changes
PyPDF2/pdf.py
field = f.getObject()
self._buildField(field, retval, fileobj, fieldAttributes)

if "/XFA" in tree:
Copy link
Copy Markdown
Member

@MartinThoma MartinThoma Jun 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the logic around "/Fields"?

@MartinThoma MartinThoma changed the title Add code to extract XML form data from Adobe ES4 PDF forms ENH: Add code to extract XML form data from Adobe ES4 PDF forms Jun 25, 2022
@MartinThoma MartinThoma added Feature needs-rebase This PR cannot be merged as the main branch is too different. You need to rebase or merge main. labels Jun 25, 2022
@georgealverson
Copy link
Copy Markdown
Contributor Author

georgealverson commented Jun 25, 2022 •
edited
Loading

At this point, I no longer recall why that was done.

I was only interested in the XFA feature so I probably just found a hook that I could use and grabbed it.

@MartinThoma
Copy link
Copy Markdown
Member

MartinThoma commented Jun 25, 2022

Thank you for the swift response!

MartinThoma added a commit that referenced this pull request Jun 25, 2022
@MartinThoma @georgealverson
ENH: Add PdfReader.xfa attribute
f86edb3 
Closes #408

Co-authored-by: George Alverson <George.Alverson@cern.ch>
@MartinThoma MartinThoma mentioned this pull request Jun 25, 2022
Merged
@MartinThoma
Copy link
Copy Markdown
Member

MartinThoma commented Jun 26, 2022

I'm closing the PR here and continue the work in #1026. I will list you as a co-author of that PR :-)

@MartinThoma MartinThoma added is-feature A feature request and removed Feature labels Jun 26, 2022
@georgealverson
Copy link
Copy Markdown
Contributor Author

georgealverson commented Jun 26, 2022

Dear Martin,

Sounds good. Thanks!

—George

MartinThoma added a commit that referenced this pull request Jul 3, 2022
@MartinThoma @georgealverson
ENH: Add PdfReader.xfa attribute (#1026)
0e18938 
Closes #408

Co-authored-by: George Alverson <George.Alverson@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinThoma MartinThoma MartinThoma left review comments

Assignees

No one assigned

Labels

is-feature A feature request needs-rebase This PR cannot be merged as the main branch is too different. You need to rebase or merge main. needs-test A test should be added before this PR is merged. Tiny Pull requests that make a tiny change - and thus should be easy to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@georgealverson @codecov-commenter @MartinThoma